Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapting the code to new api #9

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

jithesh82
Copy link

Dear Noah,

I installed noms using pip for some personal use to find that it wasn't working. Started looking on the issues and came to know that it was because of the change in api. They have totally changed various attributes. I have made changes to the code to adapt to the new api keeping your code as much as possible untouched.

One of the issues I had was nutrient_dict being imported in various modules as a global variable. So I have made nutrient_dict as class.

I have tested the package with test file you provided. It works.

Would you please kindly look into this pull request and take necessary action?

Thanks a lot for your time and your wonderful work,

Best regards,
-Jithesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant