Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODIS L2 reader update #201

Merged
merged 11 commits into from
Oct 8, 2024
Merged

MODIS L2 reader update #201

merged 11 commits into from
Oct 8, 2024

Conversation

dwfncar
Copy link
Contributor

@dwfncar dwfncar commented Oct 7, 2024

Updated MODIS reader to allow for a list of filenames, renamed swath dims.

Copy link
Member

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but seems to be missing some changes in our develop branch. Can you merge it into this PR?

@dwfncar
Copy link
Contributor Author

dwfncar commented Oct 7, 2024

Looks fine but seems to be missing some changes in our develop branch. Can you merge it into this PR?

My fork shows just 1 commit ahead of noaa-oar-arl/monetio:develop, so when I look at Sync Fork there are no new commits to fetch.

@dwfncar
Copy link
Contributor Author

dwfncar commented Oct 7, 2024

Where there changes to that file elsewhere?

@zmoon
Copy link
Member

zmoon commented Oct 7, 2024

Yeah I guess since you copied the file Git thinks you changed it back. But I'm talking about like the ---- and the logging level block. Would you mind changing those to match current develop?

Copy link
Member

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing the diff. I assume you checked the loaded time is precisely what you expect with this change?

monetio/sat/_modis_l2_mm.py Outdated Show resolved Hide resolved
monetio/sat/_modis_l2_mm.py Outdated Show resolved Hide resolved
monetio/sat/_modis_l2_mm.py Outdated Show resolved Hide resolved
monetio/sat/_modis_l2_mm.py Show resolved Hide resolved
monetio/sat/_modis_l2_mm.py Outdated Show resolved Hide resolved
monetio/sat/_modis_l2_mm.py Outdated Show resolved Hide resolved
monetio/sat/_modis_l2_mm.py Outdated Show resolved Hide resolved
@zmoon
Copy link
Member

zmoon commented Oct 7, 2024

@dwfncar I ran the formatter and merged in develop so we should get ✔ now.

@zmoon zmoon merged commit bf22dc6 into noaa-oar-arl:develop Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants