-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODIS L2 reader update #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but seems to be missing some changes in our develop branch. Can you merge it into this PR?
My fork shows just 1 commit ahead of noaa-oar-arl/monetio:develop, so when I look at Sync Fork there are no new commits to fetch. |
Where there changes to that file elsewhere? |
Yeah I guess since you copied the file Git thinks you changed it back. But I'm talking about like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reducing the diff. I assume you checked the loaded time is precisely what you expect with this change?
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
@dwfncar I ran the formatter and merged in develop so we should get ✔ now. |
Updated MODIS reader to allow for a list of filenames, renamed swath dims.