Replace look-up table canopy inputs in diffusion with AQM canopy inputs. Activate build-in diagnostics aux2d/aux3d. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aux2d/aux3d (activated with ldiag3d). Replace look-up table canopy inputs with AQM canopy inputs for canopy correction on diffusivities.
drnimbusrain
requested changes
Feb 28, 2024
physics/satmedmfvdifq.meta
Outdated
| @@ -596,6 +596,43 @@ | |||
| type = real | |||
| kind = kind_phys | |||
| intent = in | |||
| #IVAI | |||
| [claie] | |||
| standard_name = leaf_area_index_eccc | |||
There was a problem hiding this comment.
Its critical that these standard names match the exactly the standard names in the fv3atm/ccpp/data/GFS_typedefs.meta file. I make suggestions here and other variables to match what you have in fv3atm side.
Suggested change
| standard_name = leaf_area_index_eccc | |
| standard_name = canopy_leaf_area_index |
physics/satmedmfvdifq.meta
Outdated
| type = real | ||
| kind = kind_phys | ||
| [cfch] | ||
| standard_name = forest_canopy_height |
There was a problem hiding this comment.
Suggested change
| standard_name = forest_canopy_height | |
| standard_name = canopy_forest_height |
physics/satmedmfvdifq.meta
Outdated
| type = real | ||
| kind = kind_phys | ||
| [cfrt] | ||
| standard_name = forest_fraction |
There was a problem hiding this comment.
Suggested change
| standard_name = forest_fraction | |
| standard_name = canopy_forest_fraction |
physics/satmedmfvdifq.meta
Outdated
| type = real | ||
| kind = kind_phys | ||
| [cclu] | ||
| standard_name = clumping_index |
There was a problem hiding this comment.
Suggested change
| standard_name = clumping_index | |
| standard_name = canopy_clumping_index |
physics/satmedmfvdifq.meta
Outdated
| type = real | ||
| kind = kind_phys | ||
| [cpopu] | ||
| standard_name = population_density |
There was a problem hiding this comment.
Suggested change
| standard_name = population_density | |
| standard_name = canopy_population_density |
physics/satmedmfvdifq.meta_canopy
Outdated
There was a problem hiding this comment.
@iri01 technically your changes on top of this file is not needed, it was added as a placeholder for my idea canopy variables read in through UFS. It is not used, so your changes are not needed to add here, only in the physics/satmedmfvdifq.meta file.
…h their definitions in GFS_typedefs.meta
drnimbusrain
approved these changes
Feb 28, 2024
drnimbusrain
pushed a commit
that referenced
this pull request
Mar 28, 2024
Remove MYNN SFC logic from noahmpdrv.F90 and fix CMakeLists.txt authors
drnimbusrain
pushed a commit
that referenced
this pull request
Mar 28, 2024
update CODEOWNERS to replace Chunxi with Qingfu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass via diffusion interface 5 AQM canopy inputs and build-in diagnostic arrays aux2d/aux3d (activated with ldiag3d).
Replace look-up table canopy inputs in diffusion with AQM canopy inputs. Used for canopy correction on diffusivities.