Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma sm #114

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Gamma sm #114

merged 7 commits into from
Feb 27, 2024

Conversation

drnimbusrain
Copy link
Member

@drnimbusrain drnimbusrain commented Feb 9, 2024

@MaggieMarvin I have a draft branch and PR here for the gamma soil activity factor (for isoprene only), which depends on input soil moisture (in four layers) and wilting point, along with a PFT dependent cumulative root fraction used for the final weighted average gamma soil. You can please test this impact on biogenic isoprene emissions independently of my other branch/PR for historical effects. Thank you!

@angehung5 If you please can see the SE domain example gfs .NC files. I have added "soilw[1-4]" volumetric soil moistures and the "wilt" wilting points as inputs to canopy-app. Can you add the corresponding five variables ("soilw[1-4]" and "wilt") from the example .NC files as appended columns and to the example .TXT files?

You can see that it breaks the CI because the usual .txt check fails without these variables in the files.

This includes updates to the following:

gfs.t12z.20220630.sfcf023.canopy.txt
gfs.t12z.20220701.sfcf000.canopy.txt
gfs.t12z.20220701.sfcf001.canopy.txt
point_file_20220630.sfcf023.txt
point_file_20220701.sfcf000.txt
point_file_20220701.sfcf001.txt

You can share with me their location for me to add to this branch for functionality when using text files, or could create a PR back to this [gamma_sm] branch for updating the text files.

Thank you!

@drnimbusrain drnimbusrain linked an issue Feb 9, 2024 that may be closed by this pull request
@drnimbusrain drnimbusrain marked this pull request as draft February 9, 2024 02:57
@drnimbusrain
Copy link
Member Author

drnimbusrain commented Feb 9, 2024

This is currently a draft and needs thorough testing:

  • Test impacts of gamma soim for isoprene emissions against MEGANv2 and MEGANv3
  • Evaluate impacts of gamma soim for isoprene against PECORINO campaign

@drnimbusrain drnimbusrain added the enhancement New feature or request label Feb 14, 2024
@angehung5
Copy link
Collaborator

@drnimbusrain Files updated. You can also find them on Hopper: /groups/ESS/whung/canopy_wind/gfsv16_test_data

@drnimbusrain
Copy link
Member Author

drnimbusrain commented Feb 14, 2024

@drnimbusrain Files updated. You can also find them on Hopper: /groups/ESS/whung/canopy_wind/gfsv16_test_data

Thank you @angehung5 Seems it fixes the CI too since you added those variables to the text files. @MaggieMarvin is testing it using netcdf files against MEGAN and seems to be working appropriately. I will test your .txt files to make sure too.

@drnimbusrain drnimbusrain added the help wanted Extra attention is needed label Feb 16, 2024
Copy link
Collaborator

@MaggieMarvin MaggieMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after bug fix! Evaluated for 08/01/2021 1800 UTC - when turned on reduces isoprene emissions mainly over croplands by up to about 50% and improves agreement slightly with MEGAN. Input data on soil moisture and wilting point looks reasonable, and gamma factor behaves as expected. In future may want to consider MEGANv3 parameterization and expanding to other species.
map_canopyapp_bio_NA-12

@drnimbusrain
Copy link
Member Author

drnimbusrain commented Feb 22, 2024 via email

@MaggieMarvin
Copy link
Collaborator

MEGANv3 has an option to calculate gamma_sm using a photosynthesis parameter and soil wetness factor from a CLM but this may not be straightforward to implement in canopy-app. MEGANv3 otherwise uses the same parameterization from Guenther 2006 but my understanding is that it only applies soil moisture from the top layer and changes delta_theta1 to 0.04. Overall this should reduce isoprene emissions further (particularly over croplands) in our test case of 08/01/2021 1800 UTC because gamma_sm = 1 at the lowest soil layer, which is weighted more than the other layers in our current implementation.

@MaggieMarvin
Copy link
Collaborator

As far as I can tell, gamma_sm is applied to all species in MEGANv3.

@drnimbusrain drnimbusrain changed the title Gamma sm (Isoprene Only) Gamma sm Feb 26, 2024
@drnimbusrain
Copy link
Member Author

As far as I can tell, gamma_sm is applied to all species in MEGANv3.

@MaggieMarvin OK, as discussed I now changed code to allow for gamma_sm applied to all species here in canopy-app too. Let me know if you are still good, and I will merge.

@drnimbusrain drnimbusrain marked this pull request as ready for review February 27, 2024 18:36
@drnimbusrain
Copy link
Member Author

@MaggieMarvin Merging...

@drnimbusrain drnimbusrain merged commit 858861d into develop Feb 27, 2024
4 checks passed
@drnimbusrain drnimbusrain deleted the gamma_sm branch February 27, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Biogenics] Add Soil Moisture Gamma
3 participants