Use spack-stack modulefiles #56

zmoon · 2024-10-17T18:56:43Z

manually test the build on all platforms
e.g.
```
rm -rf build && cmake -B build && cmake --build build -j 4 && mpirun -n 1 ./build/bin/nexus -h
```
- Hera Intel
- WCOSS
- Orion
- Gaea C5 (with the two adjustments)
- Derecho (note doesn't work on Casper)
revise the readme instructions

Closes #39

CMakeLists.txt

modulefiles/ufs_common.lua

Co-authored-by: Zachary Moon <[email protected]>

and remove most of the Ubuntu instructions

bbakernoaa · 2024-10-25T15:21:13Z

@zmoon Compiled fine on wcoss

Did get a warning during the initial CMake step

CMake Warning (dev) at src/CMakeLists.txt:16 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Environment variable ESMF_ROOT is set to:

    /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/esmf/8.6.0

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found ESMF: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/esmf/8.6.0/lib/libesmf.a (found version "8.6.0")
CMake Warning (dev) at src/CMakeLists.txt:17 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Environment variable NetCDF_ROOT is set to:

    /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found NetCDF: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/include (found version "4.9.2") found components: Fortran
-- FindNetCDF defines targets:
--   - NetCDF_VERSION [4.9.2]
--   - NetCDF_PARALLEL [TRUE]
--   - NetCDF_C_CONFIG_EXECUTABLE [/apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/bin/nc-config]
--   - NetCDF::NetCDF_C [STATIC] [Root: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2] Lib: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/lib/libnetcdf.a
--   - NetCDF_Fortran_CONFIG_EXECUTABLE [/apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/bin/nf-config]
--   - NetCDF::NetCDF_Fortran [STATIC] [Root: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2] Lib: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/lib/libnetcdff.a
CMake Warning (dev) at src/nuopc/CMakeLists.txt:16 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Environment variable ESMF_ROOT is set to:

    /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/esmf/8.6.0

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at src/nuopc/CMakeLists.txt:17 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Environment variable NetCDF_ROOT is set to:

    /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

zmoon · 2024-10-25T15:53:21Z

We could explicitly set the policy as it suggests. For example

if(POLICY CMP0074)
  cmake_policy(SET CMP0074 OLD)
endif()

I don't see UWM doing something like that in their repo though.

telling it to ignore _ROOT variables since we have special find scripts for those on WCOSS2, it was warning about these being set for NetCDF and ESMF

modulefiles/ufs_gaea.intel.lua

Co-authored-by: Zachary Moon <[email protected]>

zmoon · 2024-10-31T17:05:53Z

@bbakernoaa does revised readme look okay to you?

README.md

note it seems CMake compiler discovery modifies this result from command to full path

bbakernoaa · 2024-11-14T16:10:48Z

whats left for this?

zmoon · 2024-11-14T16:49:03Z

whats left for this?

Were you able to try WCOSS from fresh again after the change? see if works and without warnings?

bbakernoaa · 2024-11-14T20:54:43Z

compiled

zmoon · 2024-11-14T23:27:11Z

compiled

And you didn't get those warnings from earlier in this thread?

bbakernoaa · 2024-11-15T00:03:31Z

No warning. Compiled just fine Barry Baker National Oceanic and Atmospheric Administration Air Resources Laboratory Physical Research Scientist Chemical Modeling and Emissions Group Leader NCWCP, R/ARL, Rm. 4204 5830 University Research Court College Park, Maryland 20740 Phone: ‪(301) 683-1395‬

…

On Thu, Nov 14, 2024 at 6:27 PM Zachary Moon ***@***.***> wrote: compiled And you didn't get those warnings from earlier in this thread? — Reply to this email directly, view it on GitHub <#56 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFIUVNYLZJPYAN2COE4KBGL2AUWWLAVCNFSM6AAAAABQEMQYSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZXGYYTKNBXGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

zmoon · 2024-11-15T15:37:07Z

No warning. Compiled just fine

Great, do you want to approve then (seems I can't since I opened this PR, even though it's from your fork)

previous was 3.6.2 (PR #36) although the recent PR (#56) mistakenly reverted it to 3.4.0 (PR #9) (my bad)

bbakernoaa added 5 commits October 16, 2024 17:01

Updating module files for building with current spack stack

254b8ce

adding generic linux module build

5048098

Merge remote-tracking branch 'origin/develop' into feature/modulefiles

36bbf58

remove whitespace

ee5f538

precommit issues

a721ee7

zmoon commented Oct 17, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

bbakernoaa added 2 commits October 17, 2024 19:49

remoe old files

b1481f2

remove FC etc

7d4caf9

zmoon commented Oct 18, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

zmoon commented Oct 18, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

zmoon commented Oct 18, 2024

View reviewed changes

modulefiles/ufs_common.lua Outdated Show resolved Hide resolved

bbakernoaa and others added 3 commits October 18, 2024 11:32

Update CMakeLists.txt

af46dd6

Co-authored-by: Zachary Moon <[email protected]>

Update CMakeLists.txt

c3e6bac

Co-authored-by: Zachary Moon <[email protected]>

Update ufs_common.lua

252aa43

bbakernoaa added the enhancement New feature or request label Oct 18, 2024

Update readme with UFS module file info

bafd32d

and remove most of the Ubuntu instructions

Set CMake policy 0074

6b7c815

telling it to ignore _ROOT variables since we have special find scripts for those on WCOSS2, it was warning about these being set for NetCDF and ESMF

zmoon commented Oct 30, 2024

View reviewed changes

modulefiles/ufs_gaea.intel.lua Outdated Show resolved Hide resolved

zmoon commented Oct 30, 2024

View reviewed changes

modulefiles/ufs_gaea.intel.lua Outdated Show resolved Hide resolved

bbakernoaa and others added 2 commits October 30, 2024 19:37

Update modulefiles/ufs_gaea.intel.lua

d1abbad

Co-authored-by: Zachary Moon <[email protected]>

Update modulefiles/ufs_gaea.intel.lua

b91b878

Co-authored-by: Zachary Moon <[email protected]>

bbakernoaa marked this pull request as ready for review October 30, 2024 23:38

Merge branch 'develop' into feature/modulefiles

20fe93b

zmoon commented Oct 31, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

zmoon and others added 3 commits November 1, 2024 12:02

gha-esmf moved to ARL org

9be36a7

Try unsetting WCOSS vars instead

08547f8

Print $ENV{FC}

1d57259

note it seems CMake compiler discovery modifies this result from command to full path

bbakernoaa approved these changes Nov 25, 2024

View reviewed changes

zmoon merged commit 9111dd4 into noaa-oar-arl:develop Nov 25, 2024
2 checks passed

bbakernoaa deleted the feature/modulefiles branch November 25, 2024 16:27

zmoon mentioned this pull request Nov 25, 2024

apt update in CI #64

Merged

zmoon added a commit that referenced this pull request Nov 25, 2024

Update HEMCO to 3.10.0 release

6dee43f

previous was 3.6.2 (PR #36) although the recent PR (#56) mistakenly reverted it to 3.4.0 (PR #9) (my bad)

zmoon mentioned this pull request Nov 25, 2024

Update HEMCO version to 3.10.0 #65

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use spack-stack modulefiles #56

Use spack-stack modulefiles #56

zmoon commented Oct 17, 2024 •

edited

Loading

bbakernoaa commented Oct 25, 2024

zmoon commented Oct 25, 2024 •

edited

Loading

zmoon commented Oct 31, 2024

bbakernoaa commented Nov 14, 2024

zmoon commented Nov 14, 2024

bbakernoaa commented Nov 14, 2024

zmoon commented Nov 14, 2024

bbakernoaa commented Nov 15, 2024 via email

zmoon commented Nov 15, 2024

Use spack-stack modulefiles #56

Use spack-stack modulefiles #56

Conversation

zmoon commented Oct 17, 2024 • edited Loading

bbakernoaa commented Oct 25, 2024

zmoon commented Oct 25, 2024 • edited Loading

zmoon commented Oct 31, 2024

bbakernoaa commented Nov 14, 2024

zmoon commented Nov 14, 2024

bbakernoaa commented Nov 14, 2024

zmoon commented Nov 14, 2024

bbakernoaa commented Nov 15, 2024 via email

zmoon commented Nov 15, 2024

zmoon commented Oct 17, 2024 •

edited

Loading

zmoon commented Oct 25, 2024 •

edited

Loading