Issue #51: plugin crash with java.lang.NoSuchMethodError

- Fix an incompatibility with version 13.x due to an API method removal. - Due to the API change, the minimum supported version is now IDEA 13.
nnmatveev · Jul 15, 2014 · 30a6888 · 30a6888
1 parent 3ae374e
commit 30a6888
Show file tree

Hide file tree

Showing 9 changed files with 39 additions and 16 deletions.
diff --git a/.idea/ant.xml b/.idea/ant.xml
diff --git a/.idea/compiler.xml b/.idea/compiler.xml
diff --git a/.idea/copyright/profiles_settings.xml b/.idea/copyright/profiles_settings.xml
diff --git a/.idea/misc.xml b/.idea/misc.xml
diff --git a/.idea/runConfigurations/idea_plugin_protobuf.xml b/.idea/runConfigurations/idea_plugin_protobuf.xml
diff --git a/.idea/scopes/scope_settings.xml b/.idea/scopes/scope_settings.xml
diff --git a/META-INF/plugin.xml b/META-INF/plugin.xml
@@ -12,9 +12,15 @@
         ]]>
     </description>
     <!-- please see http://confluence.jetbrains.net/display/IDEADEV/Build+Number+Ranges for description -->
-    <idea-version since-build="123"/><!-- Idea 12 -->
+    <idea-version since-build="133"/><!-- Idea 13 -->
     <change-notes>
         <![CDATA[
+        <p>0.5.7</p>
+        <ul>
+            <li>Fix an incompatibility with version 13.x due to an API method removal.</li>
+            <li>Fix an occasional error generating a safe package name for validating build item validity state.</li>
+            <li>Due to the API change, the minimum supported version is now IDEA 13.</li>
+        </ul>
         <p>0.5.6</p>
         <ul>
             <li>No longer re-compiles proto files that are up to date when using the external compiler.</li>

diff --git a/ReleaseNotes.txt b/ReleaseNotes.txt
@@ -1,3 +1,11 @@
+==== 0.5.7
+* Fix an incompatibility with version 13.x due to an API method removal.
+* Due to the API change, the minimum supported version is now IDEA 13.
+* Fix an occasional error generating a safe package name for validating build item validity state.
+
+==== 0.5.6
+* Fixes a bug in detecting the state of the generated files. The bug meant that Java files would be generated even when there was no change to the .proto files. This should speed up compilation of projects significantly.
+
 ==== 0.5.5
 * Changes to support IDEA 13.  The minimum version changed to IDEA 12.
 * Minor bug fix for collapse all in the structure view for .proto files.

diff --git a/src/protobuf/lang/psi/impl/reference/PbRefImpl.java b/src/protobuf/lang/psi/impl/reference/PbRefImpl.java
@@ -369,7 +369,8 @@ public CompletionKind getCompletionKind() {
 
     public static class ExperimentalResolver implements ResolveCache.Resolver {
 
-        public PsiElement resolve(PsiReference refElement, boolean incompleteCode) {
+        @Override
+        public PsiElement resolve(@NotNull PsiReference refElement, boolean incompleteCode) {
             final PbRefImpl ref = (PbRefImpl) refElement;
             final ReferenceKind refKind = ref.getRefKind();
             final PbRef qualifier = ref.getQualifierRef();