Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

CNV-39781: lldp vlan and system name filters #99

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

upalatucci
Copy link
Collaborator

@upalatucci upalatucci commented Mar 25, 2024

All filters

Screenshot from 2024-03-25 15-36-59

VLAN filter
Screenshot from 2024-03-25 15-37-46

System name filter
Screenshot from 2024-03-25 15-37-08

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 25, 2024

@upalatucci: This pull request references CNV-39781 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Screenshot from 2024-03-25 15-37-46
Screenshot from 2024-03-25 15-37-08
Screenshot from 2024-03-25 15-36-59
Screenshot from 2024-03-25 15-36-24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 25, 2024

@upalatucci: This pull request references CNV-39781 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

All filters

Screenshot from 2024-03-25 15-36-59

VLAN filter
Screenshot from 2024-03-25 15-37-46

System name filter
Screenshot from 2024-03-25 15-37-08

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci upalatucci force-pushed the search-by-lldp-name branch from ee64e2f to 8a3f70f Compare March 27, 2024 13:35
Copy link
Collaborator

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Ugo! 🎇

Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d18db6b into nmstate:main Mar 27, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants