Skip to content

Commit

Permalink
elyra-ai#1993 Removed deprecated formData and inputDataModel code fro…
Browse files Browse the repository at this point in the history
…m common-properties

Signed-off-by: Neha Gokhale <[email protected]>
  • Loading branch information
nmgokhale committed May 28, 2024
1 parent 1a3d88e commit b574d64
Show file tree
Hide file tree
Showing 26 changed files with 4 additions and 10,719 deletions.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ class PropertiesMain extends React.Component {
}
if (newProps.propertiesInfo) {
if (!isEqual(Object.keys(newProps.propertiesInfo), Object.keys(this.props.propertiesInfo)) ||
(newProps.propertiesInfo.formData && !isEqual(newProps.propertiesInfo.formData, this.props.propertiesInfo.formData)) ||
(newProps.propertiesInfo.parameterDef && !isEqual(newProps.propertiesInfo.parameterDef, this.props.propertiesInfo.parameterDef)) ||
(newProps.propertiesInfo.appData && !isEqual(newProps.propertiesInfo.appData, this.props.propertiesInfo.appData))) {
const sameParameterDefRendered = newProps.propertiesInfo.id === this.props.propertiesInfo.id;
Expand Down Expand Up @@ -149,18 +148,12 @@ class PropertiesMain extends React.Component {
setForm(propertiesInfo, sameParameterDefRendered) {
let formData = null;

if (propertiesInfo.formData && Object.keys(propertiesInfo.formData).length !== 0) {
formData = propertiesInfo.formData;
} else if (propertiesInfo.parameterDef) {
if (propertiesInfo.parameterDef) {
if (this.props.propertiesConfig.schemaValidation) {
validateParameterDefAgainstSchema(propertiesInfo.parameterDef);
}
formData = Form.makeForm(propertiesInfo.parameterDef, this.props.propertiesConfig.containerType);
}
// TODO: This can be removed once the WML Play service generates datasetMetadata instead of inputDataModel
if (formData && formData.data && formData.data.inputDataModel && !formData.data.datasetMetadata) {
formData.data.datasetMetadata = PropertyUtils.convertInputDataModel(formData.data.inputDataModel);
}

this.propertiesController.setForm(formData, this.props.intl, sameParameterDefRendered);
if (formData) {
Expand Down
Loading

0 comments on commit b574d64

Please sign in to comment.