Skip to content

Commit

Permalink
elyra-ai#1867 Fixed left nav subtabs CSS in tearsheet (elyra-ai#1875)
Browse files Browse the repository at this point in the history
  • Loading branch information
nmgokhale authored Apr 16, 2024
1 parent ee24d1d commit 2bc285d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,34 +32,34 @@ $selected-tab-width: 3px;

.properties-leftnav-container {
display: flex;
border-top: px solid $layer-accent-01;
height: calc(100% + #{$parent-padding}); // Include padding from parent
margin-top: -$spacing-05;
margin-left: -$spacing-05;
margin-bottom: calc(-1 * #{$parent-padding});

// TODO: Height of this class will be fixed in issue https://github.ibm.com/NGP-TWC/wdp-abstract-canvas/issues/3699
.properties-leftnav-subtabs {
width: 282px;
background-color: $layer-01;
border-right: 1px solid $layer-accent-01;
padding-top: $spacing-02;
height: 100%;
max-block-size: none; // To make the height same as parent div

.cds--tab--list {
flex-direction: column;
width: 282px;
height: fit-content;
}

button.properties-leftnav-subtab-item {
&:hover {
border-bottom: 0;
background-color: $layer-hover-01;
border-block-end: none !important; // Added !important to override carbon CSS which showed bottom border
}

border-left: $selected-tab-width solid transparent;
border-bottom: 0;
transition: none; // Prevent border/outline from flickering
max-block-size: $spacing-08;

&:focus, &:active {
outline: 0;
Expand Down
3 changes: 1 addition & 2 deletions canvas_modules/harness/assets/styles/harness.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

@use "@carbon/react/scss/themes" as *;
@use "./carbon.scss" as *;
@import "./carbon.scss";

// Switch the theme's below to change light <-> dark theme for harness
// Modify common-canvas/src/themes/light.scss to switch common-canvas.
Expand All @@ -32,7 +32,6 @@ $harness-sidepanel-width: 320px;
$harness-sidepanel-transition-time: 0.3s;
$harness-console-height: 200px;

@import "./carbon.scss";
@import "../../src/client/components/console/console.scss";
@import "../../src/styles/custom-canvases.scss";
@import "../../src/styles/canvas-customization.scss";
Expand Down

0 comments on commit 2bc285d

Please sign in to comment.