Add quality metric calculation #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implemented calculator calculates the DIV_50 metric. This simple metric is to demonstrate the proof of concept of this infrastructure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The infrastructure is designed to give the developer the maximum flexibility about how to calculate these measures. In the case of the very simple measure
DIV_50(number of frequencies in descending order, which are needed to reach a probability > 0.5) is calculated on the server itself. But more complicated or taxing measures might also be developed using AWS lambda or other tools.During development, we noticed that we should not allow the cliuent to provide quality measures themselves, so we are now ignoring client provided quality measures completely and silently. This change was also documented.
References #79