-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing input validation #15
Comments
For example this resolution field "ResolutionData": [
{
"scopeElement": null,
"resolution": "4-Field"
}
] should be validated against the enum from the yaml ResolutionInfo:
title: ResolutionInfo
properties:
scopeElement:
type: string
resolution:
type: string
description: resolution of the data
enum:
- G
- P
- gNMDP
- gDKMS
- 2-Field
- 4-Field
- 6-Field
- 8-Field
- Serology |
In a way the enums are evaluated: Invalid values are blanked. I yet have to find a way to turn this blanking off and return an error 400 instead. |
We have discussed configuring the service to refer to a second service that only performs HLA validation. The high-level requirements for this service is something that a group is discussing at WMDA. |
Also need "liftover" for dealing with renamed alleles. |
The current state of the service is a prototype. As such almost no input validation, cross checks and sanity checks are performed. They need to be implemented.
The text was updated successfully, but these errors were encountered: