Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing input validation #15

Open
fscheel opened this issue Jul 18, 2017 · 4 comments
Open

Missing input validation #15

fscheel opened this issue Jul 18, 2017 · 4 comments

Comments

@fscheel
Copy link
Contributor

fscheel commented Jul 18, 2017

The current state of the service is a prototype. As such almost no input validation, cross checks and sanity checks are performed. They need to be implemented.

@mmaiers-nmdp
Copy link
Contributor

For example this resolution field

"ResolutionData": [
    {
      "scopeElement": null,
      "resolution": "4-Field"
    }
]

should be validated against the enum from the yaml

 ResolutionInfo:
    title: ResolutionInfo
    properties:
      scopeElement:
        type: string
      resolution:
        type: string
        description: resolution of the data
        enum:
          - G
          - P
          - gNMDP
          - gDKMS
          - 2-Field
          - 4-Field
          - 6-Field
          - 8-Field
          - Serology

@fscheel
Copy link
Contributor Author

fscheel commented Nov 14, 2017

In a way the enums are evaluated: Invalid values are blanked. I yet have to find a way to turn this blanking off and return an error 400 instead.

@mmaiers-nmdp
Copy link
Contributor

We have discussed configuring the service to refer to a second service that only performs HLA validation. The high-level requirements for this service is something that a group is discussing at WMDA.

@mmaiers-nmdp
Copy link
Contributor

Also need "liftover" for dealing with renamed alleles.
Deleted alleles are a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants