Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the clients be checked in with the service? #47

Closed
mpresteg opened this issue Nov 14, 2017 · 3 comments
Closed

Should the clients be checked in with the service? #47

mpresteg opened this issue Nov 14, 2017 · 3 comments
Labels

Comments

@mpresteg
Copy link
Contributor

It implies that maintenance of the clients be synchronized with the service, which increases the burden for anyone modifying the service. There is value to the synchronization, but separation seems more appropriate.

@mmaiers-nmdp
Copy link
Contributor

This came up at the meeting on Nov 7. The naming convention for github repos (service-foo, client-foo) is being intentionally violated for phycus since for this project we are tightly coupling both the client API and the server API to the YAML. Having the API code be swagger-generated as much as possible will reduce the impact down the road when we make changes to the model.

We will reduce the churn of having the regenerate client API code if we take things like enumerated value domains out of the YAML.

for example:

          - DIV_LAMBDA
          - DIV_50
          - DIV_50_REL
          - SAM_SIZE
          - SAM_POP
          - DIV_PGD
          - DIV_HEAVY_TAIL
          - RES_TRS_COUNT
          - RES_TRS
          - RES_SHARE_AMBIG
          - RES_MISS_LOCI
          - DEV_HWE
          - ERR_STD
          - ERR_SAMP_80_100
          - SUM_FREQ_GAP
          - ERR_OFFSET
          - LD_MEASURE
          - KFOLD_IMPUTE
          - KFOLD_PRED_ACTUAL
          - KFOLD_N

@fscheel
Copy link
Contributor

fscheel commented Nov 14, 2017

Taking those enumerations out of the specs, this would also help with #15 (comment), but we'd have to document the value domain seprately.

@mpresteg
Copy link
Contributor Author

Closing - Java client with swagger code gen built in via Maven added to the service (status: pull request review). Command line tools added in multi-module java client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants