Fixed tags for the graphical condordance #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tags for the graphical concordance example were incorrect.
|
I believe this is a proper change. I can't find any situation where e.g. This can easily be verified with >>> import nltk
>>> nltk.app.concordance()and then filling in e.g. Paging @stevenbird |
Following thorugh the book, checking for VBD or VBN in cfd1 is not possible, because it is based on the universal tagset. cfd1 has to recalculated using the WSJ tagset.
In order to get the presented output words of length 3 also have to be included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tags for the graphical concordance example were incorrect.