Merge pull request #3 from nlnwa/fix/nil-pointer-exception

Fix nil pointer exception
nlnwa · Dec 13, 2023 · ddbc0b6 · ddbc0b6
2 parents e80544b + a3447c1
commit ddbc0b6
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/internal/warc/testdata/corrupt.warc.gz b/internal/warc/testdata/corrupt.warc.gz
diff --git a/internal/warc/validate.go b/internal/warc/validate.go
@@ -38,7 +38,10 @@ func IsValid(file, tmpDir string) (bool, error) {
 			return validation.Valid(), nil
 		}
 		if err != nil {
-			*validation = append(*validation, err)
+			if wr != nil {
+				defer wr.Close()
+			}
+			return false, nil
 		}
 		func() {
 			defer wr.Close()

diff --git a/internal/warc/validate_test.go b/internal/warc/validate_test.go
@@ -21,8 +21,9 @@ import (
 )
 
 const (
-	validWarcFile   = "testdata/valid.warc.gz"
-	invalidWarcFile = "testdata/invalid.warc.gz"
+	validWarcFile     = "testdata/valid.warc.gz"
+	invalidWarcFile   = "testdata/invalid.warc.gz"
+	corruptedWarcFile = "testdata/corrupt.warc.gz"
 )
 
 func TestMain(m *testing.M) {
@@ -42,6 +43,10 @@ func TestIsValid(t *testing.T) {
 			file:    invalidWarcFile,
 			isValid: false,
 		},
+		{
+			file:    corruptedWarcFile,
+			isValid: false,
+		},
 	}
 
 	for _, test := range tests {