Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands confirmation rework #347

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

nlef
Copy link
Owner

@nlef nlef commented Jan 2, 2025

The action confirmation settings have been reworked
Parameters require_confirmation_macro and require_confirmation_services have been removed and a new parameter require_confirmation_bot_commands has been added
The parameter will accept a list of bot commands, macros and gcodes for which a confirmation request will be displayed.
default values for require_confirmation_bot_commands:logs, upload_logs, shutdown, restart, cancel, fw_restart, emergency, reboot, power

@nlef nlef requested a review from aka13-404 January 2, 2025 15:00
@nlef nlef linked an issue Jan 2, 2025 that may be closed by this pull request
@nlef
Copy link
Owner Author

nlef commented Jan 2, 2025

@xdadrm
now you can customize confirmations as you like
Please test this functionality
It would be great to get feedback

@nlef nlef self-assigned this Jan 2, 2025
@nlef nlef added Feature Request New feature or request Next release Extra attention is needed labels Jan 2, 2025
@xdadrm
Copy link

xdadrm commented Jan 2, 2025

@xdadrm now you can customize confirmations as you like Please test this functionality It would be great to get feedback

Quickly tested and looks perfect - thank you @nlef !

What I did :

  • Pulled PR Commands confirmation rework #347 into my branch, restarted the bot.
  • tested upload-logs fw_restart and bot_restart - all as expected (bot_restart without confirmation)
  • added bot_restart to a new require_confirmation_bot_commands line in the config
  • tested upload-logs fw_restart and bot_restart - all as expected (bot_restart this time with confirmation)

require_confirmation_bot_commands: upload_logs,shutdown,restart,cancel,fw_restart,emergency,reboot,power,bot_restart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request Next release Extra attention is needed
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Add confirmation config for bot commands
2 participants