Adds teleport option to taskPatrol #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokoho48
reviewed
Nov 23, 2024
| @@ -34,13 +34,14 @@ switch (_mode) do { | |||
| [LSTRING(Module_TaskPatrol_Range_DisplayName), "SLIDER", LSTRING(Module_TaskPatrol_Range_ToolTip), [20, 2000], [1, 0.5], TASK_PATROL_SIZE, 1], | |||
| [LSTRING(Module_TaskPatrol_Waypoints_DisplayName), "SLIDER", LSTRING(Module_TaskPatrol_Waypoints_ToolTip), [2, 15], [2, 1], TASK_PATROL_WAYPOINTCOUNT, 0], | |||
| [LSTRING(Module_TaskPatrol_MoveWaypoints_DisplayName), "BOOLEAN", LSTRING(Module_TaskPatrol_MoveWaypoints_ToolTip), TASK_PATROL_MOVEWAYPOINTS], | |||
| [LSTRING(Module_Task_EnableReinforcement_DisplayName), "BOOLEAN", LSTRING(Module_Task_EnableReinforcement_ToolTip), TASK_PATROL_ENABLEREINFORCEMENT] | |||
| [LSTRING(Module_Task_EnableReinforcement_DisplayName), "BOOLEAN", LSTRING(Module_Task_EnableReinforcement_ToolTip), TASK_PATROL_ENABLEREINFORCEMENT], | |||
| [LSTRING(Module_TaskGarrison_Teleport_DisplayName), "BOOLEAN", LSTRING(Module_TaskGarrison_Teleport_Tooltip), TASK_PATROL_TELEPORT] | |||
There was a problem hiding this comment.
When we use it in multiple places, we should remove the Garrison from the name
rautamiekka
suggested changes
Nov 23, 2024
| @@ -12,6 +12,7 @@ | |||
| * 4: Area the AI Camps in, default [] <ARRAY> | |||
| * 5: Dynamic patrol pattern, default false <BOOL> | |||
| * 6: enable dynamic reinforcement <BOOL> | |||
| * 7: Teleport group <BOOL> | |||
There was a problem hiding this comment.
This needs far better wording. The comment for the associated code says it teleports the group to a random waypoint position, which itself is confusing cuz it means a random waypoint from the ones the group currently has.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends Modules (Zeus and Eden) with a teleport option in taskPatrol. When enabled, it functions much like Garrisons-- placing the group at at a randomly selected position with the patrol area.