-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoE Helper #39
base: master
Are you sure you want to change the base?
PoE Helper #39
Conversation
modified: poe_ext.crx modified: poe_ext/assets/bootstrap/css/bootstrap-responsive.css modified: poe_ext/assets/bootstrap/css/bootstrap-responsive.min.css modified: poe_ext/assets/bootstrap/css/bootstrap.css modified: poe_ext/assets/bootstrap/css/bootstrap.min.css modified: poe_ext/assets/bootstrap/js/bootstrap.js modified: poe_ext/assets/css/tablesorter.bootstrap.css modified: poe_ext/assets/js/file.js new file: poe_ext/assets/js/jquery-1.9.1.js modified: poe_ext/assets/js/jquery.blockUI.js modified: poe_ext/assets/js/jquery.tablesorter.js modified: poe_ext/assets/js/jquery.tablesorter.widgets.js modified: poe_ext/assets/js/track.js modified: poe_ext/itemdata.js modified: poe_ext/lite.js modified: poe_ext/main.html modified: poe_ext/main.js modified: poe_ext/manifest.json modified: poe_updates.xml
This reverts commit 7e330e9.
I had a quick look. looks nice, but it doesn't perform so well with large amounts of items. I think you'll probably need to put in an option to turn off the images. Looks like the col selection is defaulting back to everything whenever the app reloads, which is also an issue with large amounts of items. As it it was people with >100 stash tabs were already having issues with chrome deciding things were taking too long and shutting down. Anyways, if you want to sort that out i'm happy to merge it in and push the update for everyone using my autoupdate. I can't change it to update from your crx files as they need to be built/signed with my private key for the autoupdate to work. |
Yes, I know should add more options - i'll do that a bit later (when i'm more familiar with the code & have a bit more time :). I've updated to 0.91 with a bunch of requests by my friends - made smaller images & more compact table. As for people with >100 stash tabs - is such problem even solvable in chrome? We'll need a separate SQL for such amounts of data :) As for your signature - you can easily compress all that folder with your chrome & sign... |
probably the best way to deal with the insane amount of stash tabs would be It's been a while since i looked but i think the raw data is probably On Sat, May 18, 2013 at 12:30 PM, Zeracles [email protected] wrote:
|
Yes it is reparsed indeed. |
yeah, i never got around from rearranging it from when i picked it up. having the crafting separated wouldn't be a bad idea. You'll get a million On Sat, May 18, 2013 at 1:12 PM, Zeracles [email protected] wrote:
|
I have that feeling too, it makes that shiny premium colored tabs with custom names not so useful... |
What is the chaos reciepe? |
one of every slot with item level over 60 something. On Sat, May 18, 2013 at 9:55 PM, Zeracles [email protected] wrote:
|
BTW, I never used the "crafting" functionality - PoE Helper was always just a stash search tool for me... Interesting how it used by the majority, though |
Ah, And on the screeshot you can see how easy you can have a list of chestplates, that gives you >40 hp, >200 armour, sorted by required level - isn't that the most useful tool ever :) |
Looks very nice. I'll see if it copes with my 60 tabs of junk. If so I'll
|
@Zeracles Also, if you could do a filter-branch and rewrite the names of your commits that would be great. You made a bunch of commits that all have the same title and this doesn't help anyone figure out what you actually did. Leave the versioning to the maintainer and instead write a description of what the commit actually change. |
Is your project still maintained? I made some minor changes (details: http://www.pathofexile.com/forum/view-thread/385603), but more importantly, I want to maintain this one...