-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl syslog::setlogmask #2579
Impl syslog::setlogmask #2579
Conversation
Signed-off-by: tison <[email protected]>
Co-authored-by: SteveLauC <[email protected]>
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Regarding those 2 syslog C macros, I am working on sending them to the libc crate, let's merge this PR first.
@SteveLauC May we cut a release recently? |
Honestly, hard to tell, I plan to maintain open-source projects for only 7 hours per week, and there are still some I/O safety leftovers to clean, if we are lucky, we will have a release in 2 or 3 weeks |
@SteveLauC Good to know. Do you have a list of the release blockers? Or we have a label/milestone/tracking issue to list them. I may try to see if anything I can help. |
No detailed to-do lists, grep I think 90% of interfaces are already I/O-safe, the leftovers are harder to do, e.g., the ScmRights control message, original I thought the interface included in that PR should work just fine, then I realized you could send file descriptors within the same process (kinda meaningless, but nothing stops you from doing so), in this case, my interface could lead to double-close quite easily. Once this is done, do a crates-test, if we still have time:) |
This follows up #2537 and refers to #413.
cc @SteveLauC