Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl syslog::setlogmask #2579

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Impl syslog::setlogmask #2579

merged 3 commits into from
Jan 12, 2025

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Jan 5, 2025

This follows up #2537 and refers to #413.

cc @SteveLauC

src/syslog.rs Outdated Show resolved Hide resolved
tisonkun and others added 2 commits January 12, 2025 12:03
Co-authored-by: SteveLauC <[email protected]>
Signed-off-by: tison <[email protected]>
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Regarding those 2 syslog C macros, I am working on sending them to the libc crate, let's merge this PR first.

@SteveLauC SteveLauC added this pull request to the merge queue Jan 12, 2025
Merged via the queue into nix-rust:master with commit 020e6b4 Jan 12, 2025
41 checks passed
@tisonkun tisonkun deleted the setlogmask branch January 12, 2025 06:59
@tisonkun
Copy link
Contributor Author

@SteveLauC May we cut a release recently?

@SteveLauC
Copy link
Member

Honestly, hard to tell, I plan to maintain open-source projects for only 7 hours per week, and there are still some I/O safety leftovers to clean, if we are lucky, we will have a release in 2 or 3 weeks

@tisonkun
Copy link
Contributor Author

@SteveLauC Good to know. Do you have a list of the release blockers? Or we have a label/milestone/tracking issue to list them. I may try to see if anything I can help.

@SteveLauC
Copy link
Member

No detailed to-do lists, grep RawFd in the codebase, and if a raw fd can be replaced with I/O-safe fd types (OwnedFd, BorrowedFd), do it. Here is an example PR.

I think 90% of interfaces are already I/O-safe, the leftovers are harder to do, e.g., the ScmRights control message, original I thought the interface included in that PR should work just fine, then I realized you could send file descriptors within the same process (kinda meaningless, but nothing stops you from doing so), in this case, my interface could lead to double-close quite easily.

Once this is done, do a crates-test, if we still have time:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants