feat: impl Into<OwnedFd> for owned fd types #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I did not expect to see hurd CI broken here |
SteveLauC
force-pushed
the
feat/into_owned_fd
branch
from
39e1d07 to
17c8bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Implements
Into<OwnedFd> for x(Actually, it isFrom<x> for OwnedFddue to the clippy rule clippy::from_over_into) for types that are simply owned file descriptors.Types like Dir, do not only contain a file descriptor, so they are not included in this PR.
Checklist:
CONTRIBUTING.md