Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix clippy & unused imports/helper type #2416

Merged
merged 1 commit into from
May 25, 2024
Merged

refactor: fix clippy & unused imports/helper type #2416

merged 1 commit into from
May 25, 2024

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented May 24, 2024 •
edited
Loading

What does this PR do

This PR

  1. Fixes documents identification issue
  2. Adds type annotations for one usage of std::mem::transmute()
  3. Dead code analysis of the latest nightly toolchain has become smarter, there are some unused helper SetXXX/GetXXX types in src/sys/socket/sockopt.rs, this PR gates them with target and feature.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC SteveLauC changed the title ci: trigger CI error refactor: fix clippy & unused imports/helper type May 25, 2024
@SteveLauC SteveLauC added this pull request to the merge queue May 25, 2024
Merged via the queue into nix-rust:master with commit c003ae9 May 25, 2024
36 checks passed
@SteveLauC SteveLauC deleted the ci/trigger_error branch May 25, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SteveLauC