Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: I/O safety for 'sys/memfd' & 'sys/event' & 'sys/eventfd' #1928

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Dec 8, 2022

What this PR does:

Adds I/O safety for moduels:

  1. sys/memfd
  2. sys/event
  3. sys/eventfd

BYW, I called rustfmt on these 4 files, which introduces some noise, sorry about this.

@SteveLauC SteveLauC force-pushed the io-safety-memfd-event-eventfd branch from 04e0818 to 6d052a7 Compare December 8, 2022 07:44
@SteveLauC SteveLauC mentioned this pull request Dec 8, 2022
29 tasks
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please split the formatting changes out into a separate commit?

src/sys/epoll.rs Outdated Show resolved Hide resolved
SUPERCILEX added a commit to SUPERCILEX/nix that referenced this pull request Dec 9, 2022
@SUPERCILEX
Copy link
Contributor

Made the formatting changes here: #1935. CI checks are clearly still broken, I'll try and figure out why if I have time.

@SteveLauC
Copy link
Member Author

Could you please split the formatting changes out into a separate commit?

Let't merge #1935 first, then I will rebase my branch.

bors bot added a commit that referenced this pull request Dec 10, 2022
1935: Formatting only changes for #1928 and #1863 r=asomers a=SUPERCILEX



Co-authored-by: Alex Saveau <[email protected]>
@asomers
Copy link
Member

asomers commented Dec 10, 2022

I think you need to rebase to make the formatting changes go away. And the OSX aarch64 failure is spurious.

@SteveLauC SteveLauC force-pushed the io-safety-memfd-event-eventfd branch from ab164dd to 511f84b Compare December 11, 2022 04:19
@SteveLauC SteveLauC force-pushed the io-safety-memfd-event-eventfd branch from 511f84b to 27d1844 Compare December 11, 2022 04:20
@SteveLauC
Copy link
Member Author

I think you need to rebase to make the formatting changes go away. And the OSX aarch64 failure is spurious.

Rebased.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit 9f3aafc into nix-rust:master Dec 11, 2022
@SteveLauC SteveLauC deleted the io-safety-memfd-event-eventfd branch December 11, 2022 21:48
@dreiss dreiss mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants