-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: I/O safety for 'sys/memfd' & 'sys/event' & 'sys/eventfd' #1928
Conversation
04e0818
to
6d052a7
Compare
f93603b
to
8f93634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please split the formatting changes out into a separate commit?
Signed-off-by: Alex Saveau <[email protected]>
Made the formatting changes here: #1935. CI checks are clearly still broken, I'll try and figure out why if I have time. |
Let't merge #1935 first, then I will rebase my branch. |
I think you need to rebase to make the formatting changes go away. And the OSX aarch64 failure is spurious. |
ab164dd
to
511f84b
Compare
511f84b
to
27d1844
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
What this PR does:
Adds I/O safety for moduels:
sys/memfd
sys/event
sys/eventfd
BYW, I called
rustfmt
on these 4 files, which introduces some noise, sorry about this.