Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins/nvim-surround: init #2267

Merged
merged 2 commits into from
Sep 18, 2024
Merged

plugins/nvim-surround: init #2267

merged 2 commits into from
Sep 18, 2024

Conversation

khaneliman
Copy link
Contributor

Resolves #1346
Closes #1371
Rename surround to vim-surround and init nvim-surround.

@khaneliman khaneliman force-pushed the surround branch 3 times, most recently from 8af47b8 to 52138ff Compare September 18, 2024 04:18
MattSturgeon
MattSturgeon approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like how the rename migration is handled.

Feels like plugins/deprecation.nix may make #1657 redundant, if we're happy having a one-way rename with no plan for another plugin to "take over" the name at a later date.

plugins/deprecation.nix Outdated Show resolved Hide resolved
plugins/by-name/nvim-surround/default.nix Outdated Show resolved Hide resolved
plugins/by-name/nvim-surround/default.nix Outdated Show resolved Hide resolved
@khaneliman
plugins/surround: rename to vim-surround
092d1a8 
Adding nvim-surround so we need to deprecate the generic name and move
it.
@khaneliman
Copy link
Contributor Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 04ad793

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024

This pull request, with head sha 04ad7937c0f74db1a8a1b8af44c895bd91792e15, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 04ad7937c0f74db1a8a1b8af44c895bd91792e15 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch surround, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 04ad793 into nix-community:main Sep 18, 2024
4 checks passed
@khaneliman khaneliman deleted the surround branch September 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattSturgeon MattSturgeon MattSturgeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PLUGIN REQUEST] nvim-surround
3 participants
@khaneliman @MattSturgeon @theabm