Added a programs.jujutsu.configFile file option to configure output…

[aftix]

Description

Added a programs.jujutsu.configFile option to configure output location of programs.jujutsu.settings

I'm not sure if there's a convention on how to name options that relocate the config files.

Checklist

• Change is backwards compatible.

The option defaults to the exact string that was previously used.

• Code formatted with ./format.

./format slightly changed the formatting in parts of the file I didn't touch, I assume the format rules have changed since this file was last edited.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

Maintainer CC

@shikanime

[ambroisie]

Why not just follow XDG_CONFIG_FILE always?

[shikanime]

I don't think it's a good idea, similarly to other modules. Unfortunately there's some configuration files that doesn't follow the XDG spec, but I don't think jj fall into it.

[aftix]

What do you think isn't a good idea, following the XDG spec directly or having the location configurable? At this point I think the module should retain backwards compatibility and keep the file in ~/.jjconfig toml by default since I don't think jujutsu has any plans to stop supporting that location. My use case is I have XDG_CONFIG_HOME as a tmpfs and I'd like to keep configuration there

[ambroisie]

should retain backwards compatibility and keep the file in ~/.jjconfig toml by default since I don't think jujutsu has any plans to stop supporting that location.

The programs.git module changed the location, and there is precedent for other modules switching to XDG_CONFIG_HOME unconditionnaly (e.g: programs.less).

[rycee]

Thanks for the contribution! I chose to merge #5207, however. I think if the program natively supports the XDG location then we should always use that.