Skip to content

Faster nar parser

Faster nar parser #524

Triggered via pull request October 17, 2024 11:45
Status Failure
Total duration 3m 20s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 5 warnings
lint: pkg/narv2/copy.go#L42
Error return value is not checked (errcheck)
lint: pkg/narv2/reader.go#L63
Error return value of `r.fail` is not checked (errcheck)
lint: pkg/narv2/reader.go#L76
Error return value of `r.fail` is not checked (errcheck)
lint: pkg/narv2/reader.go#L97
Error return value of `r.fail` is not checked (errcheck)
lint: pkg/narv2/reader.go#L185
Error return value of `r.r.Discard` is not checked (errcheck)
lint: pkg/narv2/reader.go#L198
Error return value of `r.r.Discard` is not checked (errcheck)
lint: pkg/narv2/writer.go#L16
Error return value of `binary.Write` is not checked (errcheck)
lint: pkg/narv2/writer.go#L10
File is not `gofumpt`-ed (gofumpt)
lint: pkg/narv2/writer.go#L11
zero is a global variable (gochecknoglobals)
lint: pkg/narv2/writer.go#L27
tokNar is a global variable (gochecknoglobals)
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: pkg/narv2/reader.go#L79
increment-decrement: should replace r.depth -= 1 with r.depth-- (revive)
lint: pkg/narv2/reader.go#L114
increment-decrement: should replace r.depth += 1 with r.depth++ (revive)
lint: pkg/narv2/writer.go#L70
increment-decrement: should replace w.depth += 1 with w.depth++ (revive)
lint: pkg/narv2/writer.go#L143
increment-decrement: should replace w.depth -= 1 with w.depth-- (revive)