Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-disk-image: allow pre/post format files in vm #778

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phaer
Copy link
Member

@phaer phaer commented Sep 18, 2024

...via disko.imageBuilder.preFormatFiles and disko.imageBuilder.postFormatFiles.

This enables users to add secrets to their diskoVMs.

diskoImageScripts does include --pre-format-files, but diskoImages didn't support
the same feature so far - making it harder to pre-generate encrypted disk images or to test such images in a VM.

Copy link
Member

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants