Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): respect staleMaxAge option #2606

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

cjpearson
Copy link
Contributor

πŸ”— Linked issue

#2164

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change ensures that stale responses are only used if they have not exceeded the period defined in staleMaxAge.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@manniL
Copy link
Member

manniL commented Jul 23, 2024

Used it in my project locally and it worked fine πŸ‘πŸ»

@manniL manniL added the bug Something isn't working label Jul 23, 2024
@pi0 pi0 added the cache label Sep 20, 2024
@pi0 pi0 self-requested a review as a code owner October 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cache
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants