Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this. Make NFA a seq[Node] again.
Node.next
contains epsilon transitions now, so it becomes@[epsilon_transition_idx, epsilon_transition_idx, matchable_node_idx, epsilon_transition_idx, matchable_node_idx, matchable_node_idx, ...]
It potentially makes better use of CPU cache, or it should not be worse at least, and code is cleaner.
There is a perf regression in regexes like
"(\w|\w)(?<=\w+)foo"
where prior to this change the lookaround would only get evaluated once (for the first alternation cond) and now it's evaluated for every alternation cond. We could reorder the epsilon transitions to be evaluated after the matchable node like@[matchable_node_idx, epsilon_transition_idx]
after. However, regexes where this matter (containing unbounded lookarounds) already run in quadratic time, so meh.