Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved German translation #327

Closed
wants to merge 3 commits into from

Conversation

rbergmair
Copy link

I'm a German native speaker, and I took a stab at improving the German translation tokens.

  • added translations for some tokens that previously didn't have any translations at all
  • fixed some translations that I found highly unidiomatic. (For example "Vorlieben" for "Preferences" sounds pretty weird to my ear).
  • fixed some inconsistencies in spelling conventions e.g. upper-casing of personal pronouns (e.g. "Du" and "Dich" was previously upper-cased in line with conventions for writing letters in some, but not all cases. I uniformly used the lower-case version instead).

@nitely
Copy link
Owner

nitely commented Nov 6, 2023

hey, translations are done through transifex https://app.transifex.com/spirit-project/

@rbergmair
Copy link
Author

I've created a join request.

@nitely
Copy link
Owner

nitely commented Nov 6, 2023

I just accepted it.

@rbergmair
Copy link
Author

It seems like potentially a lot of work to rework this into transifex. Can you merge it here, and have transifex pick it up from here? Or is it a one-way street?

@nitely
Copy link
Owner

nitely commented Nov 6, 2023

mmh, if you remove all the binaries, at some point I'll merge it.

@rbergmair
Copy link
Author

That would be much appreciated, and thanks a lot for the great work you've done with this piece of software in general!

Closing in favour of #328.

@rbergmair rbergmair closed this Nov 7, 2023
@rbergmair rbergmair deleted the new_german_translations branch November 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants