dhcpv4: Replace the DiscoveryTimeout timer when discovery done #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhebox
reviewed
Jan 6, 2025
| DhcpV4Event::RequestTimeout, | ||
| )?; | ||
| self.retry_count = 0; | ||
| self.event_pool.del_timer(DhcpV4Event::DiscoveryTimeout)?; |
There was a problem hiding this comment.
I believe self.lease need to be set too. Since process_request_timeout won't send packets without lease.
We should replace `DiscoveryTimeout` timer with `RequestTimeout` when the discovery is done and entering request phase. Manually tested by checking debug logs of `cargo run --example mozim_dhcpv4_async`. DHCPv6 part does not have this problem as it has only single retry timer `DhcpV6Event::TransmitWait`. Signed-off-by: Gris Ge <[email protected]>
xhebox
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should replace
DiscoveryTimeouttimer withRequestTimeoutwhenthe discovery is done and entering request phase.
Manually tested by checking debug logs of
cargo run --example mozim_dhcpv4_async.DHCPv6 part does not have this problem as it has only single retry timer
DhcpV6Event::TransmitWait.