Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] cleaning, fixing tests #718

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Conversation

djarecka
Copy link
Collaborator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@djarecka djarecka changed the title cleaning, fixing tests [WIP] cleaning, fixing tests Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bd76c3d) 78.48% compared to head (a99494a) 82.70%.
Report is 1 commits behind head on rf/environments.

❗ Current head a99494a differs from pull request most recent head 8d60dd1. Consider uploading reports for the commit 8d60dd1 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           rf/environments     #718      +/-   ##
===================================================
+ Coverage            78.48%   82.70%   +4.21%     
===================================================
  Files                   23       23              
  Lines                 4904     4857      -47     
  Branches              1402        0    -1402     
===================================================
+ Hits                  3849     4017     +168     
+ Misses                 859      840      -19     
+ Partials               196        0     -196     
Flag Coverage Δ
unittests 82.70% <87.50%> (+4.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pydra/engine/specs.py 94.82% <ø> (+7.59%) ⬆️
pydra/engine/task.py 96.63% <100.00%> (+16.63%) ⬆️
pydra/engine/environments.py 70.58% <85.00%> (-8.11%) ⬇️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djarecka djarecka merged commit 58038f5 into nipype:rf/environments Nov 3, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant