-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructured specs and task package auto-generation script #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents on what to put for each field
tclose
changed the title
Restructured specs
Restructured specs and task package auto-generation script
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the format for the YAML specs used to assist the conversion process the tasks, adding fields to rename the task and fields and override the inferred field types.
It also adds the
scripts/create_packages.py
script, which scrapesnipype.interfaces
to generate separate stub git repos for each of the task packages (e.g. pydra-ants, pydra-afni, pydra-fsl, pydra-dipy, etc...) that are pre-populated with auto-generated YAML files with info inferred from doctests. See pydra-ants-autodemo for an example of what the repositories would look like.We should be able to use the script to quickly create separate repos for each tool package in Nipype. The GH actions are designed to then have the packages automatically convert all the Nipype interfaces and publish release whenever a new nipype or nipype2pydra version is released.
The nipype2pydra conversion step will generate a unittest for each interface, that attempts to initialise the task with sensible values and run it for 10s. If it makes it that far it is considered to have passed the initialisation phase and is marked as passed. The values passed to the fields are determined by their types, and for selected file-types (e.g. NIfTI, DICOM) the fileformats package is able to provide sample filesets using a package I wrote called
medimages4tests
.I have tried to explain the process in the README of pydra-ants-autodemo, let me know if it doesn't make sense with and adds scripts for auto-generating new package repos