Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore init_resample_midthickness_wf for backwards compatibility #462

Closed
wants to merge 1 commit into from

Conversation

effigies
Copy link
Member

Sorry @mgxd. Try out this branch?

@effigies effigies force-pushed the fix/resample-midthickness branch from 81e4c65 to cc4fb34 Compare December 13, 2024 02:40
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.19%. Comparing base (7f2863a) to head (cc4fb34).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #462       +/-   ##
===========================================
+ Coverage   63.12%   74.19%   +11.07%     
===========================================
  Files          25       25               
  Lines        1955     1957        +2     
  Branches      245      245               
===========================================
+ Hits         1234     1452      +218     
+ Misses        683      440      -243     
- Partials       38       65       +27     
Flag Coverage Δ
ds054 45.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd
Copy link
Collaborator

mgxd commented Dec 13, 2024

@effigies I'm fine with using https://github.com/nipreps/smriprep/tree/dev-nibabies for the time being - will shift back to master shortly after a nibabies release

@effigies
Copy link
Member Author

@mgxd The plan is just to pin to a dev branch, or do you need a release without that change in? If you're pushing to pypi, you'll presumably need a PyPI release.

@mgxd
Copy link
Collaborator

mgxd commented Dec 16, 2024

i just pushed an alpha to docker hub to get hbcd processing underway - plan is to sync up before the 25.0.0 release

@effigies
Copy link
Member Author

Got it.

@effigies effigies closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants