fix: do not use pointers for env maps #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using pointers breaks kong's arg parsing somewhat as it fails to merge multiple values of the same arg. Removing the pointer fixes that while still making it possible to detect if the arg has been supplied or not as a map has nil as the zero value.
ctrox
force-pushed
the
fix-env-update
branch
from
a2c14ce to
1f574d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using pointers breaks kong's arg parsing somewhat as it fails to merge multiple values of the same arg. Removing the pointer fixes that while still making it possible to detect if the arg has been supplied or not as a map has nil as the zero value.