fix: allow enabling git auth using update command #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was fast! Thanks :) I'll let one of the team approve it though! |
ctrox
force-pushed
the
fix-git-auth-update
branch
from
1a1fc79 to
977a1d8
Compare
the update command just updates the secret if it already exists, meaning it fails if you want to enable git auth after creating the app. This will call create if the secret could not be found.
ctrox
force-pushed
the
fix-git-auth-update
branch
from
977a1d8 to
b5829e5
Compare
pawelkuc
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the update command just updates the secret if it already exists, meaning it fails if you want to enable git auth after creating the app. This will call create if the secret could not be found.