Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set-org command #64

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix set-org command #64

merged 1 commit into from
Sep 22, 2023

Conversation

pawelkuc
Copy link
Contributor

This PR fixes the nctl auth set-org command so that it no longer overrides the login method currently defined in .kube/config (static API token or OIDC) with OIDC.

It also adds a small feature to display a list of available organizations when an organization name is not specified (only for OIDC login method).

auth/config.go Outdated Show resolved Hide resolved
auth/config.go Show resolved Hide resolved
auth/whoami.go Outdated Show resolved Hide resolved
auth/whoami.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
Copy link
Contributor

@thirdeyenick thirdeyenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@pawelkuc pawelkuc merged commit b0c56b9 into main Sep 22, 2023
2 checks passed
@pawelkuc pawelkuc deleted the fix-set-org branch September 22, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants