Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrote if statement to simplfy the forbidden error #183

Merged
merged 6 commits into from
Oct 31, 2024
Merged

wrote if statement to simplfy the forbidden error #183

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b42acd
wrote if statement to simplfy the forbidden error
saaadAF Oct 30, 2024
a162c14
fixed the if statement according to nick
saaadAF Oct 30, 2024
f5da871
adding --verbose parameter for detailed error
saaadAF Oct 31, 2024
222e78b
Simplify permission error handling
saaadAF Oct 31, 2024
e8cd662
changed verbose message
saaadAF Oct 31, 2024
a7dc18f
fixing typos
saaadAF Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import (

"github.com/alecthomas/kong"

k8serrors "k8s.io/apimachinery/pkg/api/errors"

completion "github.com/jotaen/kong-completion"
"github.com/ninech/nctl/api"
"github.com/ninech/nctl/api/util"
Expand All @@ -34,6 +36,7 @@ type flags struct {
APICluster string `help:"Context name of the API cluster." default:"${api_cluster}" env:"NCTL_API_CLUSTER"`
LogAPIAddress string `help:"Address of the deplo.io logging API server." default:"https://logs.deplo.io" env:"NCTL_LOG_ADDR"`
LogAPIInsecure bool `help:"Don't verify TLS connection to the logging API server." hidden:"" default:"false" env:"NCTL_LOG_INSECURE"`
Verbose bool `help:"Show detailed error message."`
SaadAssaf marked this conversation as resolved.
Show resolved Hide resolved
Version kong.VersionFlag `name:"version" help:"Print version information and quit."`
}

Expand Down Expand Up @@ -154,7 +157,15 @@ func main() {
os.Exit(1)
}

kongCtx.FatalIfErrorf(kongCtx.Run(ctx, client))
err = kongCtx.Run(ctx, client)
if err != nil {
if k8serrors.IsForbidden(err) && !nctl.Verbose {
kongCtx.Fatalf("Permission denied: are you part of the organization?\nuse --verbose to see detailed error")
SaadAssaf marked this conversation as resolved.
Show resolved Hide resolved
}else{
kongCtx.FatalIfErrorf(err)
}
}

}

func setupSignalHandler(ctx context.Context, cancel context.CancelFunc) {
Expand Down