Fix resource listing #171
Merged
Fix resource listing #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with listing of resources. To list resources we need to first gather all the projects of a user. Afterwards we can search for the corresponding type in each project.
ctrox
approved these changes
Oct 2, 2024
Yeah, true this a negative side effect. This could be changed by adding an option, but I'd say it is rather uncommon to have something like an 'admin' option in such a tool. |
ctrox
reviewed
Oct 2, 2024
thirdeyenick
force-pushed
the
fix-listing
branch
from
9ed81ab to
91733f4
Compare
To overcome some import cycles, this commit moves the kubeconfig extension type and also functions related to the kubeconfig into its own package.
thirdeyenick
force-pushed
the
fix-listing
branch
from
91733f4 to
f5944ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the not working resource listing over all projects. We now search for the users projects and search in them for the corresponding resource if
--all-projects/-Awas given. As this required quite some changes in test setups (projects have to be around when testing the--all-projectsfunctionality), this PR also extends the internal test framework which can be used to setup a fake clientset. All manual creations of fake clientsets have been replaced by the test framework.The main changes of this PR are in
internal/test/client.goandget/get.go. All the other changes are test framework adaptions or cleanups of existing tests.