Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add missing build variables #165

Merged
merged 1 commit into from
Sep 23, 2024
Merged

build: add missing build variables #165

merged 1 commit into from
Sep 23, 2024

Conversation

thde
Copy link
Member

@thde thde commented Sep 23, 2024

No description provided.

@thde thde mentioned this pull request Sep 23, 2024
Closed
ctrox
ctrox approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ctrox ctrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this won't directly fix the issue mentioned in #160 (comment) but it's good to set this explicitly anyways.

@rnestler
Copy link

I think this won't directly fix the issue mentioned in #160 (comment) but it's good to set this explicitly anyways.

I can fix it the same way in the source build, by passing a commit hash.

@thde
Copy link
Member Author

thde commented Sep 23, 2024

I think this won't directly fix the issue mentioned in #160 (comment) but it's good to set this explicitly anyways.

Correct it wont. But it makes it more obvious what variables can be defined.

@thde thde merged commit 431589e into main Sep 23, 2024
2 checks passed
@thde thde deleted the thde/build-info branch September 23, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrox ctrox ctrox approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thde @rnestler @ctrox