fix: improve logbox interrupt handling #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thirdeyenick
approved these changes
Jul 24, 2024
This fixes a number of issues with the cancel/error handling while the logbox (tea program) is running. Previously input was sent to the tea program, which meant we had to handle ctrl+c/ctrl+d explicitly. Now the tea program is stopped using the context and also in afterWait since it's important to call `p.Wait()` so that the console is restored properly before nctl exits.
When a user quits nctl while it is waiting for create/delete, we should only show "timeout waiting for ..." if the context deadline is reached. If the contact was simply canceled we should just exit without a special message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of issues with the cancel/error handling while the
logbox (tea program) is running. Previously input was sent to the tea
program, which meant we had to handle ctrl+c/ctrl+d explicitly. Now the
tea program is stopped using the context and also in afterWait since
it's important to call
p.Wait()so that the console is restoredproperly before nctl exits.