Merge pull request #124 from ninech/no-env-update

fix: do not update/sort env vars when nothing changes
ninech · Jul 10, 2024 · bbcf0c9 · bbcf0c9
2 parents 5ee8326 + 6815ad4
commit bbcf0c9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/api/util/apps.go b/api/util/apps.go
@@ -73,6 +73,10 @@ func EnvVarsFromMap(env map[string]string) apps.EnvVars {
 }
 
 func UpdateEnvVars(oldEnvs []apps.EnvVar, newEnvs map[string]string, toDelete []string) apps.EnvVars {
+	if len(newEnvs) == 0 && len(toDelete) == 0 {
+		return oldEnvs
+	}
+
 	envMap := map[string]apps.EnvVar{}
 	for _, v := range oldEnvs {
 		envMap[v.Name] = v