Transaction validity and to-plain conversion for PoW transactions #3187
+958
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
force-pushed
the
nibhar/tx-history
branch
from
fffc91b to
82bd171
Compare
jsdanielh
reviewed
Dec 12, 2024
PoW contract creation data was different than in PoS, leading to failing deserializations when converting a transaction to its plain format in the web-client.
Added special handling for PoW network IDs and added tests for basic txs, vesting and HTLC creation txs and HTLC claiming txs.
Where it makes sense.
The problem was the merkle path, whose serialization changed in PoS.
Also - refactor `genesis_number` => `genesis_block_number` - clean up example page changes
sisou
force-pushed
the
nibhar/tx-history
branch
from
602b7f3 to
0e54f87
Compare
sisou
changed the title
|
Ready for review. |
jsdanielh
reviewed
Dec 12, 2024
| @@ -74,6 +74,7 @@ build-data = "0.2" | |||
| serde_json = "1.0" | |||
|
|
|||
| nimiq-test-log = { workspace = true } | |||
| nimiq-web-client = { workspace = true, default-features = false, features = ["primitives"] } | |||
There was a problem hiding this comment.
The default-features = false is inherited from the workspace
Suggested change
| nimiq-web-client = { workspace = true, default-features = false, features = ["primitives"] } | |
| nimiq-web-client = { workspace = true, features = ["primitives"] } |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure PoW transactions can be properly converted to their plain representation, which is primarily done during address transaction history fetching in the web-client. Before this change, PoW transactions could not be returned and the process panicked, due to different serializations of contract creation data, HTLC proofs and signature proofs.
I have tried to document all changes and differences in code comments, let me know if you require more info, here or in the code.
Pull request checklist
clippyandrustfmtwarnings.