Reduce reliance on blake2 internals, move RequestCommon::*serialize*
#2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
force-pushed
the
hrxi/minor_fixes41
branch
from
1eabf5f
to
4be17db
Compare
hrxi
added
the
testnet-restart
|
Requires regenerating the ZKP keys. Maybe we can get rid of the blake2-rfc dependency entirely once the |
hrxi
force-pushed
the
hrxi/minor_fixes41
branch
from
4be17db
to
96cf992
Compare
Simply add the personalization to the hashed data instead of using the BLAKE2 personalization feature.
Implementers shouldn't override it.
jsdanielh
force-pushed
the
hrxi/minor_fixes41
branch
from
96cf992
to
91701ed
Compare
jsdanielh
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.