Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Sync main and release 0.3.0 #50

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

phongvhd93
Copy link
Collaborator

What happened 👀

This PR is to solve a conflict of iOS project between 2 branches main and release/0.3.0

Insight 📝

  • Pick the conflict file from develop

Proof Of Work 📹

The sample project works as expected.

Screenshot 2023-12-04 at 12 10 47

Copy link

github-actions bot commented Dec 4, 2023

8 Warnings
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ android/src/main/java/co/nimblehq/kmm/template/ui/screens/home/HomeScreen.kt#L66 - This expression contains a magic number. Consider defining it to a well named constant.
⚠️ shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
⚠️ shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt#L18 - Exception is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
⚠️ shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
⚠️ shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: 59.92%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Gemfile.lock
project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

Copy link

github-actions bot commented Dec 4, 2023

Current coverage for sample is 18.25%

No files affecting coverage found


Powered by xcov

Generated by 🚫 Danger

@luongvo
Copy link
Member

luongvo commented Dec 5, 2023

@phongvhd93 Do you have another PR to sync main back to develop?

@phongvhd93
Copy link
Collaborator Author

@phongvhd93 Do you have another PR to sync main back to develop?

I'll open another one after release pr get merged

@phongvhd93 phongvhd93 merged commit 052b610 into release/0.3.0 Dec 5, 2023
2 checks passed
@phongvhd93 phongvhd93 deleted the chore/sync-main-and-release-0.3.0 branch December 5, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants