Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#292] Update TF version and GH actions versions #293

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[#292] Update TF version and GH actions versions #293

merged 2 commits into from
Jul 31, 2024

Conversation

Nihisil
Copy link
Contributor

@Nihisil Nihisil commented May 10, 2024

What happened 👀

  • Upgrade TF to 1.8.3 version
  • Upgrade GH actions to latest versions
  • Install TF and node through asdf instead of manual installation

Proof Of Work 📹

CI is green.

@Nihisil Nihisil self-assigned this May 10, 2024
@Nihisil Nihisil added this to the 2.4.0 milestone May 10, 2024
longnd
longnd approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@longnd longnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a cleaner way to install dependencies. I will borrow it to other projects I'm working on 🤩

.github/workflows/test.yml Show resolved Hide resolved
@Nihisil
Copy link
Contributor Author

Nihisil commented May 10, 2024

It is a cleaner way to install dependencies. I will borrow it to other projects I'm working on 🤩

Yep, I like it as well. It was introduced by @nvminhtue in his PR: #262

malparty
malparty approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@Nihisil Nihisil merged commit b9a45f8 into develop Jul 31, 2024
3 checks passed
@Nihisil Nihisil deleted the chore/gh-292-update-deps branch July 31, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@sanG-github sanG-github sanG-github approved these changes

@nvminhtue nvminhtue nvminhtue approved these changes

@bterone bterone bterone approved these changes

@hoangmirs hoangmirs hoangmirs approved these changes

@longnd longnd longnd approved these changes

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@liamstevens111 liamstevens111 Awaiting requested review from liamstevens111 liamstevens111 is a code owner

Assignees

@Nihisil Nihisil

Labels
type : chore
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Update TF version and GH actions versions
7 participants
@Nihisil @longnd @hoangmirs @bterone @nvminhtue @sanG-github @malparty