[#254] Prevent creating the login credential for IAM bot account #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nihisil
requested review from
hoangmirs,
andyduong1920,
bterone,
byhbt,
longnd,
malparty,
nvminhtue and
liamstevens111
as code owners
longnd
approved these changes
Dec 1, 2023
hoangmirs
deleted the
feature/gh-254-remove-login-credentials-from-bot-account
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
List of implemented improvements:
has_login = false). It is unnecessary for service account to have console login and exposes more risk. Credentials that will be used by service account can be generated through admin account.bottoinfra-service-account, since this name is more accurate describe why we need this accountdepends_onattribute togroup_membership. Withoutdepends_onthere was an error when we tried to add new user, it said that user wasn't created yet.group_membershipto be set through forloop, to make it easier change attributes (otherwise we had to set samedepends_onfor all three memberships).Proof Of Work 📹
TF plan can be run and applied without any errors: