[#91] Fix: Move database migration right after the database initializing #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangmirs
approved these changes
Mar 8, 2023
Comment on lines
+61
to
+66
| return fmt.Sprintf("postgres://%s:%s@%s:%s/%s?sslmode=disable", | ||
| viper.GetString("db_username"), | ||
| viper.GetString("db_password"), | ||
| viper.GetString("db_host"), | ||
| helpers.GetStringConfig("db_port"), | ||
| helpers.GetStringConfig("db_name"), |
There was a problem hiding this comment.
Should we take this chance to drop the use of config/app.toml file? And change to use .env files instead.
With that file, we will get confused when adding new environment variables, as we don't know where we should put them
There was a problem hiding this comment.
As this PR is opened for so long, let's do it in another PR. I've created an issue to do it 🙇🏼
Nihisil
approved these changes
Mar 22, 2023
sleepylee
approved these changes
Mar 22, 2023
carryall
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #91
What happened 👀
Move the database migration right after the database is initialized, just like we did in Varun API project
Insight 📝
N/A
Proof Of Work 📹
All test passed