moving phx_host to mix_release

nimblehq · Mar 3, 2022 · 77be419 · 77be419
1 parent 65473dd
commit 77be419
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 24 deletions.
diff --git a/lib/nimble_template/addons/github.ex b/lib/nimble_template/addons/github.ex
@@ -89,21 +89,6 @@ defmodule NimbleTemplate.Addons.Github do
       "url: [scheme: \"https\", host: host,"
     )
 
-    Generator.replace_content(
-      "config/runtime.exs",
-      """
-        host = System.get_env("PHX_HOST") || "example.com"
-      """,
-      """
-        host =
-          System.get_env("PHX_HOST") ||
-            raise \"\"\"
-            Environment variable PHX_HOST is missing.
-            Set the Heroku endpoint to this variable.
-            \"\"\"
-      """
-    )
-
     Generator.append_content(
       "config/prod.exs",
       """

diff --git a/lib/nimble_template/addons/variants/phoenix/mix_release.ex b/lib/nimble_template/addons/variants/phoenix/mix_release.ex
@@ -65,6 +65,21 @@ defmodule NimbleTemplate.Addons.Phoenix.MixRelease do
       """
     )
 
+    Generator.replace_content(
+      "config/runtime.exs",
+      """
+        host = System.get_env("PHX_HOST") || "example.com"
+      """,
+      """
+        host =
+          System.get_env("PHX_HOST") ||
+            raise \"\"\"
+            Environment variable PHX_HOST is missing.
+            Set the Heroku endpoint to this variable.
+            \"\"\"
+      """
+    )
+
     project
   end
 end
diff --git a/priv/templates/nimble_template/.github/wiki/Environment-Variables.md.eex b/priv/templates/nimble_template/.github/wiki/Environment-Variables.md.eex
@@ -8,3 +8,5 @@
 ### Endpoint configuration
 
 - `HEALTH_PATH`: Health path (eg: "/_health")
+- `PHX_HOST`: The application endpoint.
+- `SECRET_KEY_BASE`: Secret key base
diff --git a/test/nimble_template/addons/github_test.exs b/test/nimble_template/addons/github_test.exs
@@ -304,15 +304,6 @@ defmodule NimbleTemplate.Addons.GithubTest do
                    config :nimble_template, NimbleTemplate.Repo,
                      ssl: true,
                  """
-
-          assert file =~ """
-                   host =
-                     System.get_env("PHX_HOST") ||
-                       raise \"\"\"
-                       Environment variable PHX_HOST is missing.
-                       Set the Heroku endpoint to this variable.
-                       \"\"\"
-                 """
         end)
       end)
     end

diff --git a/test/nimble_template/addons/variants/mix_release_test.exs b/test/nimble_template/addons/variants/mix_release_test.exs
@@ -46,6 +46,15 @@ defmodule NimbleTemplate.Addons.Phoenix.MixReleaseTest do
                      server: true,
                  """
 
+          assert file =~ """
+                   host =
+                     System.get_env("PHX_HOST") ||
+                       raise \"\"\"
+                       Environment variable PHX_HOST is missing.
+                       Set the Heroku endpoint to this variable.
+                       \"\"\"
+                 """
+
           refute file =~ """
 
                    # ## Using releases