Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#586] Migrate to build version catalog #591

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ryan-conway
Copy link
Collaborator

#586

What happened 👀

  • Created libs.versions.toml
  • Deleted Dependencies.kt and Plugins.kt
  • Migrated app, data, domain and project gradle files to use new version catalog file

TODO 🏃🏻

  • Update sample-compose

Insight 📝

  • We cannot delete Versions.kt as we cannot migrate all versions to the version catalog cleanly 🫠
  • COMPOSE_COMPILERversion will be removed in another PR 🙇🏻

Proof Of Work 📹

App still builds and runs

@ryan-conway ryan-conway added this to the 3.31.0 milestone Nov 4, 2024
@ryan-conway ryan-conway self-assigned this Nov 4, 2024
@ryan-conway ryan-conway changed the title [#586] Migrate to version catalog [#586] Migrate to build version catalog Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 61.54%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Versions.kt
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
libs.versions.toml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant