-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#586] Migrate to build version catalog #591
Draft
ryan-conway
wants to merge
1
commit into
develop
Choose a base branch
from
feature/586-migrate-to-build-version-catalog
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-conway
had a problem deploying
to
template-compose
November 4, 2024 11:27 — with
GitHub Actions
Error
ryan-conway
changed the title
[#586] Migrate to version catalog
[#586] Migrate to build version catalog
Nov 4, 2024
ryan-conway
temporarily deployed
to
template-compose
November 4, 2024 11:27 — with
GitHub Actions
Inactive
Kover report for template-compose:🧛 Template - Compose Unit Tests Code Coverage:
|
File | Coverage |
---|
Modified Files Not Found In Coverage Report:
Versions.kt
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
libs.versions.toml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#586
What happened 👀
libs.versions.toml
Dependencies.kt
andPlugins.kt
app
,data
,domain
andproject
gradle files to use new version catalog fileTODO 🏃🏻
Insight 📝
Versions.kt
as we cannot migrate all versions to the version catalog cleanly 🫠COMPOSE_COMPILER
version will be removed in another PR 🙇🏻Proof Of Work 📹
App still builds and runs