[#493] Update code according to PR comment for template_review_pull_r…

…equest.yml
nimblehq · Jun 26, 2024 · db8238c · db8238c
1 parent 2a358de
commit db8238c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 20 deletions.
diff --git a/.github/workflows/review_pull_request.yml b/.github/workflows/review_pull_request.yml
@@ -53,6 +53,7 @@ jobs:
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: '2.7'
+          bundler-cache: true
 
       - name: Cache gems
         uses: actions/cache@v2
@@ -62,16 +63,6 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gems-
 
-      - name: Install Bundle and check environment versions
-        run: |
-          echo 'Install Bundle'
-          bundle config path vendor/bundle
-          bundle install
-          echo 'Check environment setup versions'
-          ruby --version
-          gem --version
-          bundler --version
-
       - name: Run Danger
         env:
           DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/....github/workflows/review_pull_request.yml → ...orkflows/template_review_pull_request.yml b/....github/workflows/review_pull_request.yml → ...orkflows/template_review_pull_request.yml
@@ -13,7 +13,7 @@ jobs:
     if: github.event.pull_request.draft == false
     name: Review pull request
     runs-on: ubuntu-latest
-    environment: dev
+    environment: staging
     timeout-minutes: 30
     steps:
       - name: Checkout source code
@@ -38,15 +38,6 @@ jobs:
           distribution: 'temurin'
           java-version: '17'
 
-      - name: Run Detekt
-        run: ./gradlew detekt
-
-      - name: Run Android Lint
-        run: ./gradlew lintDevDebug
-
-      - name: Run unit tests with Kover
-        run: ./gradlew koverXmlReport
-
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with: