Merge pull request #125 from nimblehq/release/3.1.0

[Release] 3.1.0

.github/ISSUE_TEMPLATE/story_template.md

@@ -0,0 +1,22 @@
+---
+name: "Story"
+about: "Open a feature story"
+title: "[Type] As a user, I can "
+labels: "type : feature"
+---
+
+## Why
+
+Describe the idea of the user story as in what the motive of the user story is.
+
+## Acceptance Criteria
+
+List down how the user story will be tested and what criteria are necessary for the user story to be accepted.
+
+## Design
+
+(Optional) Add design screenshots or Figma links for UI/UX-related stories.
+
+## Resources
+
+(Optional) Add useful resources such as links to documentation, implementation ideas, or best practices.

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,13 +1,17 @@
+Note: for a release PR, append this parameter `?template=release_template.md` to the current URL to apply the release PR template, e.g. `{Github PR URL}?template=release_template.md`
+
+--
+
 https://github.com/nimblehq/android-templates/issues/??
 
 ## What happened 👀
 
-Describe the big picture of your changes here to communicate to the team why we should accept this pull request. 
- 
+Describe the big picture of your changes here to communicate to the team why we should accept this pull request.
+
 ## Insight 📝
 
 Describe in details how to test the changes, which solution you tried but did not go with, referenced documentation is welcome as well.
- 
+
 ## Proof Of Work 📹
 
 Show us the implementation: screenshots, gif, etc.

.github/PULL_REQUEST_TEMPLATE/RELEASE_TEMPLATE.md

@@ -0,0 +1,17 @@
+Link to the milestone on Github e.g. https://github.com/nimblehq/git-templates/milestone/41?closed=1
+or
+Link to the project management tool for the release
+
+## Features
+
+Provide the ID and title of the issue in the section for each type (feature, chore and bug). The link is optional.
+
+- [ch1234] As a user, I can log in
+  or
+- [[ch1234](https://github.com/nimblehq/git-templates/issues/1234)] As a user, I can log in
+
+## Chores
+- Same structure as in  ## Feature
+
+## Bugs
+- Same structure as in  ## Feature

CoroutineTemplate/app/src/main/AndroidManifest.xml

@@ -9,6 +9,7 @@
         android:allowBackup="true"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
+        android:networkSecurityConfig="@xml/network_security_config"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:supportsRtl="true"
         android:theme="@style/AppTheme">

CoroutineTemplate/app/src/main/res/xml/network_security_config.xml

@@ -0,0 +1 @@
+<network-security-config />

CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml

@@ -0,0 +1,18 @@
+<network-security-config>
+    <debug-overrides>
+        <trust-anchors>
+            <!-- Only trust user added CAs while app is debuggable -->
+            <certificates src="user" />
+            <certificates src="system" />
+        </trust-anchors>
+    </debug-overrides>
+
+    <domain-config>
+        <!-- Enter your base URL here -->
+        <domain includeSubdomains="true">www.jsonplaceholder.typicode.com</domain>
+        <trust-anchors>
+            <certificates src="user" />
+            <certificates src="system" />
+        </trust-anchors>
+    </domain-config>
+</network-security-config>

RxJavaTemplate/app/src/main/res/xml/network_security_config.xml

@@ -1,6 +1 @@
-<?xml version="1.0" encoding="utf-8"?>
-<network-security-config>
-    <domain-config cleartextTrafficPermitted="true">
-        <domain includeSubdomains="true">monkeyuser.com</domain>
-    </domain-config>
-</network-security-config>
+<network-security-config />

RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml

@@ -0,0 +1,18 @@
+<network-security-config>
+    <debug-overrides>
+        <trust-anchors>
+            <!-- Only trust user added CAs while app is debuggable -->
+            <certificates src="user" />
+            <certificates src="system" />
+        </trust-anchors>
+    </debug-overrides>
+
+    <domain-config>
+        <!-- Enter your base URL here -->
+        <domain includeSubdomains="true">www.reddit.com</domain>
+        <trust-anchors>
+            <certificates src="user" />
+            <certificates src="system" />
+        </trust-anchors>
+    </domain-config>
+</network-security-config>

RxJavaTemplate/data/src/production/java/co/nimblehq/rxjava/data/service/common/secrets/ApiEndpointUrlImpl.kt

@@ -2,5 +2,5 @@ package co.nimblehq.rxjava.data.service.common.secrets
 
 class ApiEndpointUrlImpl : ApiEndpointUrl {
     override val value: String
-        get() = TODO("Not implement yet, please modify this for your Production usage")
+        get() = "https://www.reddit.com/"
 }